Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: dock widget does not appear at previous place #44

Closed
khareusky opened this issue May 2, 2020 · 4 comments
Closed

Bug: dock widget does not appear at previous place #44

khareusky opened this issue May 2, 2020 · 4 comments
Labels
bug Something isn't working hard_to_do

Comments

@khareusky
Copy link

khareusky commented May 2, 2020 •
edited
Loading

Steps:

  1. Attach several dock widgets to some floating window
  2. try to hide one of dock widget (toggleAction()->setChecked(false))
  3. then show it (toggleAction()->setChecked(true))

Result: This dock widget does not appear at previos place.

Bug only with floating windows.
Window 10, Qt 5.11.0 and Qt 5.14.1
@iamsergio iamsergio changed the title Bug: dock widget does not appear at previos place Bug: dock widget does not appear at previous place Jun 4, 2020
@iamsergio iamsergio added the bug Something isn't working label Jun 4, 2020
@iamsergio
Copy link
Contributor

"Previous Place" only supported for Main Window, as FloatingWindows are temporary.
Need to do some refactorings/cleanups first before implementing this

@iamsergio iamsergio mentioned this issue Nov 23, 2020
Closed
@nandishnan4
Copy link

nandishnan4 commented Nov 23, 2021 •
edited
Loading

Hi @iamsergio ,
any idea when can we expect a fix for this issue. Initially the ticket I opened is marked Duplicate and closed. (#96)

Kind Regards
Nandish

@iamsergio
Copy link
Contributor

Not sure, a fix would be intrusive and create more bugs than it fixes.
I'm now concentrating on Thomas bug #256 for macOS side

@tlaemmlein
Copy link

@iamsergio
I understand that the case is difficult. But can you please check again, if there is a solution?
Kind Regards,
Thomas

iamsergio added a commit that referenced this issue Mar 7, 2022
@iamsergio
Make redocking floating windows with tabs possible
0099a19 
TitleBar::isFloating() was returning false, while it should
have returned true.

Fixed by making isFloating() simpler and dumb. isFloating() should
only say if it belongs to a floating window or not. It shouldn't
contain any logic about whether button should be visible or not.

There's already logic elsewhere that will hide the float button
in case there's nesting.

Fixes issue #96 and #44
iamsergio added a commit that referenced this issue Mar 7, 2022
@iamsergio
Update ChangeLog regarding #44 and #96 being fixed
c0e8fe3
iamsergio added a commit that referenced this issue Jun 18, 2022
@iamsergio
Make redocking floating windows with tabs possible
66b91c1 
TitleBar::isFloating() was returning false, while it should
have returned true.

Fixed by making isFloating() simpler and dumb. isFloating() should
only say if it belongs to a floating window or not. It shouldn't
contain any logic about whether button should be visible or not.

There's already logic elsewhere that will hide the float button
in case there's nesting.

Fixes issue #96 and #44

(cherry-picked from commit 0099a19)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working hard_to_do
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@iamsergio @khareusky @tlaemmlein @nandishnan4