Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch-refactoring #12

Merged
merged 13 commits into from
Mar 17, 2024
Merged

patch-refactoring #12

merged 13 commits into from
Mar 17, 2024

Conversation

KeidsID
Copy link
Owner

@KeidsID KeidsID commented Mar 15, 2024

Refactoring codebase.

  • Make "core" folders as flutter package (packages/screen_pal_core).

@KeidsID KeidsID requested a review from KeidsIDAlt March 15, 2024 00:36
@KeidsID KeidsID self-assigned this Mar 15, 2024
github-actions bot pushed a commit that referenced this pull request Mar 15, 2024
@KeidsID
web-preview build from PR #12
e883d57
@KeidsID KeidsID requested review from KeidsIDAlt and removed request for KeidsIDAlt March 15, 2024 03:35
github-actions bot pushed a commit that referenced this pull request Mar 15, 2024
@KeidsID
web-preview build from PR #12
0190ba0
@KeidsID KeidsID requested review from KeidsIDAlt and removed request for KeidsIDAlt March 15, 2024 15:25
github-actions bot pushed a commit that referenced this pull request Mar 15, 2024
@KeidsID
web-preview build from PR #12
10a1ef8
@KeidsID KeidsID requested review from KeidsIDAlt and removed request for KeidsIDAlt March 15, 2024 15:35
github-actions bot pushed a commit that referenced this pull request Mar 15, 2024
@KeidsID
web-preview build from PR #12
a2d52ae
@KeidsID KeidsID requested review from KeidsIDAlt and removed request for KeidsIDAlt March 15, 2024 16:05
github-actions bot pushed a commit that referenced this pull request Mar 15, 2024
@KeidsID
web-preview build from PR #12
57e9b0f
@KeidsID KeidsID requested review from KeidsIDAlt and removed request for KeidsIDAlt March 15, 2024 16:22
github-actions bot pushed a commit that referenced this pull request Mar 15, 2024
@KeidsID
web-preview build from PR #12
39229e1
@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.85714% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 93.53%. Comparing base (9a6a522) to head (636b27b).

Files Patch % Lines
.../src/entities/person/credits/tv_credit_person.dart 80.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   86.22%   93.53%   +7.30%     
==========================================
  Files          49       44       -5     
  Lines         334      232     -102     
==========================================
- Hits          288      217      -71     
+ Misses         46       15      -31

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KeidsID KeidsID removed the request for review from KeidsIDAlt March 16, 2024 18:02
@KeidsID KeidsID requested a review from KeidsIDAlt March 16, 2024 18:02
github-actions bot pushed a commit that referenced this pull request Mar 16, 2024
@KeidsID
web-preview build from PR #12
dd91ae0
@KeidsID KeidsID requested review from KeidsIDAlt and removed request for KeidsIDAlt March 17, 2024 07:48
github-actions bot pushed a commit that referenced this pull request Mar 17, 2024
@KeidsID
web-preview build from PR #12
f5d4d4f
@KeidsID KeidsID requested review from KeidsIDAlt and removed request for KeidsIDAlt March 17, 2024 07:51
github-actions bot pushed a commit that referenced this pull request Mar 17, 2024
@KeidsID
web-preview build from PR #12
157ed6d
KeidsIDAlt
KeidsIDAlt approved these changes Mar 17, 2024
View reviewed changes
Copy link
Collaborator

@KeidsIDAlt KeidsIDAlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥🔥🔥

@KeidsIDAlt KeidsIDAlt self-requested a review March 17, 2024 08:29
github-actions bot pushed a commit that referenced this pull request Mar 17, 2024
@KeidsID
web-preview build from PR #12
12aab31
@KeidsID KeidsID merged commit 2d1145c into main Mar 17, 2024
4 checks passed
@KeidsID KeidsID deleted the patch-refactor-mar24 branch March 17, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KeidsIDAlt KeidsIDAlt KeidsIDAlt approved these changes

Assignees

@KeidsID KeidsID

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KeidsID @codecov-commenter @KeidsIDAlt