Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creates ISSUE_TEMPLATE.md #218

Merged
merged 3 commits into from
Jan 31, 2018
Merged

Creates ISSUE_TEMPLATE.md #218

merged 3 commits into from
Jan 31, 2018

Conversation

rsangole
Copy link
Collaborator

My template proposal for an 'issue template'. Based off of experience at work and https://github.com/maqetta/maqetta/wiki/Severity-and-Priority-of-Issues

Will increase quality of 'issues' raised by users of the project.

My template proposal for an 'issue template'. Based off of experience at work and https://github.com/maqetta/maqetta/wiki/Severity-and-Priority-of-Issues
Copy link
Collaborator

@Hugovdberg Hugovdberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea to streamline issues! I added a few suggestions for further improvements to the template.

## Steps to Reproduce Behavior

## Issue Severity Classification - Select from:
### (1) Severe - Fully impedes usage of `ProjectTemplate`. This condition requires an immediate solution. `ProjectTemplate` is unable to operate or caused other critical software to fail and there is no acceptable way to work around the problem.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you replace ### (1) with simply 1. (and so on for the other numbers). The text is now marked as headers, which looks pretty bad on the eye.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, will do. PR to be sent shortly.

## Issue Severity Classification - Select from:
### (1) Severe - Fully impedes usage of `ProjectTemplate`. This condition requires an immediate solution. `ProjectTemplate` is unable to operate or caused other critical software to fail and there is no acceptable way to work around the problem.
### (2) Moderate - Significant impact. `ProjectTemplate` is usable but is limited. Work around exists, but requires significant effort. [Incomplete/incorrect documentation, poor or unexplained log messages where no clear error was evident, side effect is observed which does not significantly harm operations etc]
### (3) Low - Minimal impact. Issue is an annoyance, but I can get work done. This indicates the problem causes little impact on operations or that a reasonable circumvention to the problem has been implemented. [Usability quirks, requires minor documentation updates, or could be enhance with some minor changes to the function.]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm missing an option for feature requests. Those are actually pretty common on this project, and I disagree with https://github.com/maqetta/maqetta/wiki/Severity-and-Priority-of-Issues that enhancement shouldn't be reported this way. Of course a nice PR is preferable, but we can't expect everyone to be able to actually contribute code themselves.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, we should get something for feature requests too. I'll split the template into "bugs/issues" and "feature requests".

@rsangole
Copy link
Collaborator Author

@Hugovdberg I've improved the issue template significantly after surveying other templates available on the web. Have a look.

Copy link
Collaborator

@Hugovdberg Hugovdberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a fine template to me, thanks for the update!

@rsangole
Copy link
Collaborator Author

@Hugovdberg Have you accepted the PR already and shall I close this out, then?

@Hugovdberg
Copy link
Collaborator

Unfortunately I do not have write permissions to the project, so we'll have to wait for @KentonWhite to merge the PR (if he does agree with me your proposal is useful of course). But you have my vote!

@KentonWhite
Copy link
Owner

KentonWhite commented Jan 30, 2018

Like the template! Quick question: For this PR, why was ProjectTemplate.RProj renamed to ABC.RProj?

@rsangole
Copy link
Collaborator Author

rsangole commented Jan 30, 2018 via email

@rsangole
Copy link
Collaborator Author

Fixed. Ready for merge.

@KentonWhite KentonWhite merged commit 5167e50 into KentonWhite:master Jan 31, 2018
Hugovdberg pushed a commit to Hugovdberg/ProjectTemplate that referenced this pull request Mar 3, 2018
* Create ISSUE_TEMPLATE.md

My template proposal for an 'issue template'. Based off of experience at work and https://github.com/maqetta/maqetta/wiki/Severity-and-Priority-of-Issues

* Improves issue template

* Fixes .RProj name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants