Added feather reader #239
Merged
Added feather reader #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! Thanks @Hugovdberg . This will be very useful indeed. I like how you use the checklist buttons to make a list and cross things off as you work through the feature. I'm going to adopt this method. |
|
@rsangole Perhaps we can create a pull request template as for new issues so we can remind people to which steps should be taken before a pull request can be merged. Just a simple list of "add functionality", "add tests", "add code documentation", "add website documentation". |
|
Yep, good idea. Done. Check it out. |
KentonWhite
pushed a commit
that referenced
this pull request
May 1, 2018
* Marked addin functions as internal * Removed internal .require.package from exposed documentation * Added internal documentation for require.package * Fixed typo in the documentation * Combined documentation for file readers * Marked cache.name as internal * Marked clean.variable.name as internal * Documented the internal functions of cache.R * Documented the internal functions of clear.R * Documented the internal functions of create.project.R * Documented the internal functions of create.template.R * Documented the internal functions of get.project.R * Documented the internal functions of list.data.R * Documented the internal functions of load.project.R * Documented the internal functions of stopifnotproject.R * Added feather reader (#239) * Added feather reader * Added feather to suggested packages * Added feather reader to website documentation * Added feather reader to preinstalled readers * Marked addin functions as internal * Removed internal .require.package from exposed documentation * Added internal documentation for require.package * Fixed typo in the documentation * Combined documentation for file readers * Marked cache.name as internal * Marked clean.variable.name as internal * Documented the internal functions of cache.R * Documented the internal functions of clear.R * Documented the internal functions of create.project.R * Documented the internal functions of create.template.R * Documented the internal functions of get.project.R * Documented the internal functions of list.data.R * Documented the internal functions of load.project.R * Documented the internal functions of stopifnotproject.R * Rewrote feather.reader documentation in new format * Trigger Travis CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although implementing
featherfor the cache takes a little more time (#225), adding a reader for the format is quite straightforward (#237). This makes it easier to import output from a python or R script in the feather format.feather.readerman