fix #605 - check delete by serializing item one last time. #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinJump
added a commit
that referenced
this pull request
Apr 17, 2024
KevinJump
added a commit
that referenced
this pull request
Apr 17, 2024
* From v13: Fixes (#590) - missing null check * From v13: Fixes #604. don't prepend path with ~ (for no random reason!) * From v13: Fix #224 - Observe root folder value in rootfolder array if set (and root folders array is not set). (#606) * From v13: Throw for duplicates ( Jumoo/uSync.Complete.Issues#225 ) * Add serializers and handlers for webhooks. (#613) * Add serializers and handlers for webhooks. * Webhook Comments * From v13: Add serializers and handlers for webhooks. (#613) * From v13: Fix #609 Default language importing. (#614) * From v13: Use folders provided in options over config (#610) * From v13: fix #605 - check delete by serializing item one last time. (#616) * From v13: Fix - delete entries show up twice in report and actions. (#617) * From v13: #612 - couple of extra checks so we never try to create an XCData section with a null value. (#618) * Fix for #619. don't report property deletes as changes when they have… (#621) * Fix for #619. don't report property deletes as changes when they have already happened * Add fix for #620 - don't recreate items that are deleted. * v13 - > v14 null checks. * From v13: DataType merging Empty items alway win * update build script * tidy up logging. * consistant JSON options * Add Extra saves for content (not sure we need them! - might be a rc1 issue) * Add Ability to change the editor alias on import * Post RC1 - migration fixes. * chore: project things
KevinJump
added a commit
that referenced
this pull request
Apr 19, 2024
* From v13: Fixes (#590) - missing null check * From v13: Fixes #604. don't prepend path with ~ (for no random reason!) * From v13: Fix #224 - Observe root folder value in rootfolder array if set (and root folders array is not set). (#606) * From v13: Throw for duplicates ( Jumoo/uSync.Complete.Issues#225 ) * Add serializers and handlers for webhooks. (#613) * Add serializers and handlers for webhooks. * Webhook Comments * From v13: Add serializers and handlers for webhooks. (#613) * From v13: Fix #609 Default language importing. (#614) * From v13: Use folders provided in options over config (#610) * From v13: fix #605 - check delete by serializing item one last time. (#616) * From v13: Fix - delete entries show up twice in report and actions. (#617) * From v13: #612 - couple of extra checks so we never try to create an XCData section with a null value. (#618) * Fix for #619. don't report property deletes as changes when they have… (#621) * Fix for #619. don't report property deletes as changes when they have already happened * Add fix for #620 - don't recreate items that are deleted. * v13 - > v14 null checks. * From v13: DataType merging Empty items alway win * update build script * tidy up logging. * consistant JSON options * Add Extra saves for content (not sure we need them! - might be a rc1 issue) * Add Ability to change the editor alias on import * Post RC1 - migration fixes. * chore: project things * fixes #629 have a custom Operations handler just for uSync swagger endpoint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #605
for a delete we normally create an empty xml node, but this doesn't contain things like the items content type, so the rules break.
this fix serialized a node normally (into memory) one last time so we can do checks against the rules using this full export node, before calculating if we indeed do need to export the clean 'empty' xml node for the delete.