Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vendor extension: CESIUM_primitive_outline #1797

Merged
merged 10 commits into from
Apr 28, 2020
Merged

Add vendor extension: CESIUM_primitive_outline #1797

merged 10 commits into from
Apr 28, 2020

Conversation

kring
Copy link
Contributor

@kring kring commented Apr 28, 2020

emackey
emackey approved these changes Apr 28, 2020
View reviewed changes
Copy link
Member

@emackey emackey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is vendor-specific and the associated PR is already merged into the vendor's app, I'll merge the spec here.

Thanks @kring!

@emackey emackey merged commit ea7fde7 into KhronosGroup:master Apr 28, 2020
@emackey
Copy link
Member

emackey commented Apr 28, 2020

/cc CesiumGS/cesium#8776

@pjcozzi
Copy link
Member

pjcozzi commented Apr 28, 2020

@kring looks great to me at glance.

All - even though this was merged, feedback is very welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emackey emackey emackey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kring @emackey @pjcozzi