Fix items disposition on pool overflow on JS and KN (ktorio/ktor#956)

Kotlin · Feb 15, 2019 · 1435028 · 1435028
1 parent 7dca7f6
commit 1435028
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/js/src/kotlinx/io/pool/DefaultPool.kt b/js/src/kotlinx/io/pool/DefaultPool.kt
@@ -23,8 +23,11 @@ actual abstract class DefaultPool<T : Any> actual constructor(actual final overr
 
     actual final override fun recycle(instance: T) {
         validateInstance(instance)
-        if (size == capacity) disposeInstance(instance)
-        instances[size++] = instance
+        if (size == capacity) {
+            disposeInstance(instance)
+        } else {
+            instances[size++] = instance
+        }
     }
 
     actual final override fun dispose() {

diff --git a/native/src/kotlinx/io/pool/DefaultPool.kt b/native/src/kotlinx/io/pool/DefaultPool.kt
@@ -23,8 +23,11 @@ actual abstract class DefaultPool<T : Any> actual constructor(actual override fi
 
     actual final override fun recycle(instance: T) {
         validateInstance(instance)
-        if (size == capacity) disposeInstance(instance)
-        instances[size++] = instance
+        if (size == capacity) {
+            disposeInstance(instance)
+        } else {
+            instances[size++] = instance
+        }
     }
 
     actual final override fun dispose() {