Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protobuf allow field number to be set to value non in specification #1566

Closed
DaviDeMeo opened this issue Jun 23, 2021 · 0 comments
Closed

Protobuf allow field number to be set to value non in specification #1566

DaviDeMeo opened this issue Jun 23, 2021 · 0 comments
Labels
bug protobuf

Comments

@DaviDeMeo
Copy link

Describe the bug
E.g.: it allow to set a field number to 0.

To Reproduce

@Serializable
data class Box(@ProtoNumber(0) val number: Int)

Expected behavior
Shoud throw an error, this is not spec compliant as it should only allow value between 1 and 229 - 1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug protobuf
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sandwwraith @DaviDeMeo