Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Liquidation Pnl #58

Closed
2 tasks done
Tburm opened this issue Jun 8, 2022 · 0 comments
Closed
2 tasks done

Fix Liquidation Pnl #58

Tburm opened this issue Jun 8, 2022 · 0 comments
Assignees
@Tburm
Labels
bug Something isn't working

Comments

@Tburm
Copy link

Tburm commented Jun 8, 2022 •
edited
Loading

Liquidation position pnl is showing as >100%

Cap liquidation losses to initial margin + total deposits. This occurs when funding is really high or closing price results in excess losses taken by the debt pool.

  • pnlWithFeesPaid is never >100% for a position
  • Implement pnlWithFeesPaid on frontend queries
@Tburm Tburm self-assigned this Jun 8, 2022
@Tburm Tburm added the bug Something isn't working label Jun 8, 2022
@Tburm Tburm mentioned this issue Jun 8, 2022
Merged
@Tburm Tburm mentioned this issue Jun 30, 2022
Merged
@platschi platschi closed this as completed Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tburm Tburm

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@platschi @Tburm