Realized pnl percent #935
Merged
Realized pnl percent #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![github-advanced-security[bot]](https://avatars.github.com/in/57789?s=60&v=4){kind=small}
|
One blocker to merging this is a subgraph issue: |
|
Solved the above on the frontend by capping losses at |
platschi
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a realized pnl percentage where relevant
Description
Adds realized pnl percentage:
Related issue
Motivation and Context
We show a percentage for unrealized pnl, but not for realized pnl
How Has This Been Tested?
Placed trades on testnet and checked the values returned (total deposits, net transfers, realized pnl % for positions)
Screenshots (if appropriate):
Position Card:
Leaderboard:
