Refactor: Trade size bug (#1154)

* check for divide by zero * fixed height on balance * remove fixed height * fix account bug
Kwenta · Jul 21, 2022 · 7132127 · 7132127
1 parent fdc1a73
commit 7132127
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/constants/queryKeys.ts b/constants/queryKeys.ts
@@ -226,7 +226,11 @@ export const QUERY_KEYS = {
 			market,
 			walletAddress,
 		],
-		MarketsPositions: (markets: string[] | []) => ['futures', 'marketsPositions', markets],
+		MarketsPositions: (
+			networkId: NetworkId,
+			walletAddress: string | null,
+			markets: string[] | []
+		) => ['futures', 'marketsPositions', networkId, walletAddress, markets],
 		Positions: (networkId: NetworkId, markets: string[] | [], walletAddress: string) => [
 			'futures',
 			'positions',

diff --git a/queries/futures/useGetFuturesPositionForMarkets.ts b/queries/futures/useGetFuturesPositionForMarkets.ts
@@ -26,7 +26,7 @@ const useGetFuturesPositionForMarkets = (
 	const assets = futuresMarkets?.map(({ asset }) => asset) ?? [];
 
 	return useQuery<FuturesPosition[] | []>(
-		QUERY_KEYS.Futures.MarketsPositions(assets || []),
+		QUERY_KEYS.Futures.MarketsPositions(network.id, walletAddress, assets || []),
 		async () => {
 			if (!markets || (walletAddress && !isL2)) {
 				return [];

diff --git a/sections/futures/PositionCard/PositionCard.tsx b/sections/futures/PositionCard/PositionCard.tsx
@@ -109,7 +109,8 @@ const PositionCard: React.FC<PositionCardProps> = ({ currencyKeyRate, mobile })
 			const existingValue = positionHistory.avgEntryPrice.mul(positionHistory.size);
 			const newValue = previewTradeData.price.mul(potentialTrade.size);
 			const totalValue = existingValue.add(newValue);
-			return totalValue.div(totalSize);
+
+			return totalSize.gt(0) ? totalValue.div(totalSize) : null;
 		}
 		return null;
 	}, [positionHistory, previewTradeData, potentialTrade]);