Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add transaction notifier for useExchange txns #1140

Merged
merged 4 commits into from
Jul 19, 2022

Conversation

koredefashokun
Copy link
Contributor

Description

This PR makes the transaction notifier show up for exchange-related transactions.

Related issue

N/A

Motivation and Context

N/A

How Has This Been Tested?

N/A

Screenshots (if appropriate):

@vercel
Copy link

vercel bot commented Jul 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
kwenta ✅ Ready (Inspect) Visit Preview Jul 19, 2022 at 8:30PM (UTC)

@vercel vercel bot temporarily deployed to Preview July 19, 2022 18:48 Inactive
@vercel vercel bot temporarily deployed to Preview July 19, 2022 19:49 Inactive
Copy link
Contributor

@avclarke avclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one place we can remove some code duplication.

sections/exchange/hooks/useExchange.ts Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview July 19, 2022 20:09 Inactive
@vercel vercel bot temporarily deployed to Preview July 19, 2022 20:30 Inactive
Copy link
Contributor

@avclarke avclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@koredefashokun koredefashokun merged commit 63b413b into dev Jul 19, 2022
@Tburm Tburm mentioned this pull request Jul 19, 2022
@platschi platschi deleted the transaction-exchange branch September 29, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants