Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/share-modal-on-mobile #1258

Closed
wants to merge 17 commits into from
Closed

Conversation

KngZhi
Copy link
Contributor

@KngZhi KngZhi commented Aug 11, 2022

Description

  • feat: add share button on mobile
  • feat: basic layout for mobile modal
  • feat: add download btn and adjust size
  • feat: condition on shareicon

Related issue

PR closes Kwenta/kwenta-private#602;

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

image

@vercel
Copy link

vercel bot commented Aug 11, 2022

@KngZhi is attempting to deploy a commit to the Kwenta Team on Vercel.

A member of the Team first needs to authorize it.

text-align: center;
font-size: 14.35vw;
color: ${(props) =>
props.isGreater && props.isGreater ? props.theme.colors.green : props.theme.colors.red};

Check warning

Code scanning / CodeQL

Identical operands

Operands [props.isGreater](1) and [props.isGreater](2) are identical.
margin-top: 3.3vw;
text-shadow: 0px 0px 3.99vw
${(props) =>
props.isGreater && props.isGreater ? 'rgba(127, 212, 130, 0.35)' : 'rgb(255, 4, 32, 0.35)'};

Check warning

Code scanning / CodeQL

Identical operands

Operands [props.isGreater](1) and [props.isGreater](2) are identical.
@KngZhi KngZhi marked this pull request as ready for review August 16, 2022 06:05
@vercel
Copy link

vercel bot commented Aug 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
kwenta ❌ Failed (Inspect) Nov 28, 2022 at 1:08PM (UTC)

@vercel vercel bot temporarily deployed to Preview August 16, 2022 14:42 Inactive
@platschi platschi self-requested a review August 16, 2022 15:34
@vercel vercel bot temporarily deployed to Preview August 22, 2022 12:57 Inactive
@vercel vercel bot temporarily deployed to Preview September 13, 2022 14:46 Inactive
@vercel vercel bot temporarily deployed to Preview September 21, 2022 14:47 Inactive
@vercel vercel bot temporarily deployed to Preview October 4, 2022 12:50 Inactive
@vercel vercel bot temporarily deployed to Preview October 24, 2022 14:07 Inactive
@platschi platschi changed the title feat/share-modal-on-mible feat/share-modal-on-mobile Nov 28, 2022
@vercel vercel bot temporarily deployed to Preview November 28, 2022 13:08 Inactive
@platschi platschi changed the base branch from dev to perps-v2-dev December 22, 2022 19:55
@platschi platschi closed this Jan 19, 2023
@KngZhi KngZhi deleted the share-modal branch January 29, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants