Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search bar to the dashboard's market list #2322

Merged
merged 2 commits into from
May 9, 2023

Conversation

LeifuChen
Copy link
Contributor

@LeifuChen LeifuChen commented May 8, 2023

Description

Add a search bar to the market similar to what has been added for the markets drop-down selector.

Related issue

Kwenta/kwenta-private#160

Motivation and Context

How Has This Been Tested?

  1. Open the Dashboard page
  2. Type the market in the search bar
  3. Show the correct market in the table

Screenshots (if appropriate):

image

@vercel
Copy link

vercel bot commented May 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
kwenta ✅ Ready (Inspect) Visit Preview May 9, 2023 3:41pm
kwenta-storybook ✅ Ready (Inspect) Visit Preview May 9, 2023 3:41pm

@platschi
Copy link
Collaborator

platschi commented May 9, 2023

  • Can we add the search bar to the /dashboard/markets page, too?

  • Would it be possible to also include the full perp label into the search? In the example below, to find the Bitcoin market I have to search "BTC", but it would be great to be able to search for "Bitcoin" and find the bitcoin market, too

Screenshot 2023-05-09 at 10 39 01

@LeifuChen
Copy link
Contributor Author

  • Can we add the search bar to the /dashboard/markets page, too?
  • Would it be possible to also include the full perp label into the search? In the example below, to find the Bitcoin market I have to search "BTC", but it would be great to be able to search for "Bitcoin" and find the bitcoin market, too

Screenshot 2023-05-09 at 10 39 01

@platschi All the requested changes have been made. Thanks.

@platschi platschi merged commit 0462db2 into dev May 9, 2023
@avclarke avclarke deleted the feat/search-bard-dashboard branch June 12, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants