Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Incorrect trade preview values #2328

Merged
merged 5 commits into from
May 11, 2023
Merged

Fix: Incorrect trade preview values #2328

merged 5 commits into from
May 11, 2023

Conversation

avclarke
Copy link
Contributor

@avclarke avclarke commented May 10, 2023

Description

Fixes incorrect values displaying in smart margin trade preview

  • Correct fill price display
  • Show price impact
  • Fix liquidation price to include premium
  • Use fee value calculated from preview
  • Pass skew adjusted price to trade previews

Related issue

closes Kwenta/kwenta-private#103

@vercel
Copy link

vercel bot commented May 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
kwenta ✅ Ready (Inspect) Visit Preview May 11, 2023 10:52pm
kwenta-storybook ✅ Ready (Inspect) Visit Preview May 11, 2023 10:52pm

platschi
platschi previously approved these changes May 10, 2023
platschi
platschi previously approved these changes May 11, 2023
platschi
platschi previously approved these changes May 11, 2023
* add exact liquidation price

* remove async

* prevent trades

* fix short positions
@platschi platschi merged commit 1ef718b into dev May 11, 2023
@avclarke avclarke deleted the fix/trade-preview branch June 12, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants