Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the mobile view of market details #2350

Merged
merged 8 commits into from
May 17, 2023

Conversation

LeifuChen
Copy link
Contributor

@LeifuChen LeifuChen commented May 16, 2023

Description

Show all the market info on the mobile following the design
image

Related issue

closes Kwenta/kwenta-private#388

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

image
image

@vercel
Copy link

vercel bot commented May 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
kwenta ✅ Ready (Inspect) Visit Preview May 17, 2023 3:11pm
kwenta-storybook ✅ Ready (Inspect) Visit Preview May 17, 2023 3:11pm

@LeifuChen LeifuChen changed the title [WIP] Update the mobile view of market details Update the mobile view of market details May 16, 2023
Copy link
Contributor

@avclarke avclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of minor clean up things which could be good to include.

sections/futures/MarketDetails/MarketDetails.tsx Outdated Show resolved Hide resolved
sections/futures/MarketDetails/MarketDetails.tsx Outdated Show resolved Hide resolved
avclarke
avclarke previously approved these changes May 17, 2023
Copy link
Contributor

@avclarke avclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good!

@platschi
Copy link
Collaborator

platschi commented May 17, 2023

Screenshot 2023-05-17 at 11 36 33

What if we add a space between OI(L) and (S), as in OI (Long) and OI (Short) for better readability?

@platschi platschi merged commit 8d716af into dev May 17, 2023
@avclarke avclarke deleted the feat/update-market-details-mobile branch June 12, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants