Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Remove the blog link from banner #2609

Merged
merged 6 commits into from
Jul 15, 2023
Merged

Fix: Remove the blog link from banner #2609

merged 6 commits into from
Jul 15, 2023

Conversation

LeifuChen
Copy link
Contributor

@LeifuChen LeifuChen commented Jul 15, 2023 •
edited
Loading

Description

  1. Remove the blog link from the banner
  2. Shor normal mouse cursor if the message is unclickable
  3. Update the app version to v7.4.3

Related issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

platschi and others added 6 commits July 13, 2023 19:04
@platschi
v7.4.1
36efa20 
v7.4.1
@platschi
v7.4.2
e8efa5f 
v7.4.2
@LeifuChen
V7.4.2 (#2607)
9426c4a 
* Fix: Blank space under banner after network switching and V1 staked escrowed balance (#2605)

Fixed the banner white space in escrow tab and added v1 unstaked escrowed balance

* Update the pyth trading view endpoint (#2606)
@LeifuChen
Merge branch 'main' into dev
6624b73
@LeifuChen
Merge branch 'dev' of https://github.com/Kwenta/kwenta into dev
12532f4
@LeifuChen
Remove blogs and align the cursor style if no details; Update the app…
3a86db3 
… version
@vercel
Copy link

vercel bot commented Jul 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
kwenta ✅ Ready (Inspect) Visit Preview Jul 15, 2023 1:27pm
kwenta-storybook ✅ Ready (Inspect) Visit Preview Jul 15, 2023 1:27pm

@codecov
Copy link

codecov bot commented Jul 15, 2023 •
edited
Loading

Codecov Report

Merging #2609 (3a86db3) into dev (304410b) will decrease coverage by 0.01%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##              dev    #2609      +/-   ##
==========================================
- Coverage   50.73%   50.73%   -0.01%     
==========================================
  Files         378      378              
  Lines       11381    11383       +2     
  Branches     2683     2685       +2     
==========================================
+ Hits         5774     5775       +1     
- Misses       5386     5387       +1     
  Partials      221      221
Impacted Files Coverage Δ
...p/src/sections/shared/Layout/HomeLayout/Banner.tsx 41.30% <33.33%> (-0.92%) ⬇️
packages/app/src/queries/rates/constants.ts 60.00% <50.00%> (-15.00%) ⬇️
packages/app/src/constants/announcement.ts 100.00% <100.00%> (+12.50%) ⬆️
...sections/shared/Layout/AppLayout/Header/Header.tsx 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Marko-roy
Marko-roy approved these changes Jul 15, 2023
View reviewed changes
Copy link

@Marko-roy Marko-roy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@LeifuChen LeifuChen requested a review from avclarke July 15, 2023 13:34
@LeifuChen LeifuChen merged commit 51dd78a into dev Jul 15, 2023
5 of 6 checks passed
@LeifuChen LeifuChen deleted the fix/remove-irrelevant-blogs-from-banner branch July 15, 2023 14:42
insulineru pushed a commit that referenced this pull request Jul 24, 2023
@LeifuChen @insulineru
Fix: Remove the blog link from banner (#2609)
82a27ee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marko-roy Marko-roy Marko-roy approved these changes

@avclarke avclarke Awaiting requested review from avclarke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LeifuChen @Marko-roy @platschi