Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add AWS bucket support #2629

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Fix: Add AWS bucket support #2629

merged 2 commits into from
Jul 19, 2023

Conversation

LeifuChen
Copy link
Contributor

@LeifuChen LeifuChen commented Jul 19, 2023

Description

Add support to fetch the trading rewards file from aws bucket. After this fix, we are fetching kwenta-status.json from fleek storage and trading rewards file from aws.

Related issue

Motivation and Context

How Has This Been Tested?

Test some random address
0x24c35D308f4771930f24ca2Ed9FC911E2785572C
0x16d1663A00d4d1a216E0baa84B0AbC69ba35C156

Screenshots (if appropriate):

截屏2023-07-19 14 40 32 截屏2023-07-19 14 40 32

@vercel
Copy link

vercel bot commented Jul 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
kwenta ✅ Ready (Inspect) Visit Preview Jul 19, 2023 0:03am
kwenta-storybook ✅ Ready (Inspect) Visit Preview Jul 19, 2023 0:03am

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #2629 (7825b4c) into dev (0310bcf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #2629   +/-   ##
=======================================
  Coverage   51.31%   51.31%           
=======================================
  Files         381      381           
  Lines       11486    11486           
  Branches     2723     2723           
=======================================
  Hits         5894     5894           
  Misses       5368     5368           
  Partials      224      224           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@LeifuChen LeifuChen marked this pull request as ready for review July 19, 2023 11:42
Copy link
Contributor

@avclarke avclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, looks good!

@avclarke avclarke merged commit 66f6ff2 into dev Jul 19, 2023
5 checks passed
@avclarke avclarke deleted the fix/switch-aws-bucket branch July 19, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants