-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add position history table #2709
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## dev Kwenta/kwenta#2709 +/- ##
==========================================
- Coverage 51.27% 51.26% -0.01%
==========================================
Files 382 382
Lines 11540 11553 +13
Branches 2757 2752 -5
==========================================
+ Hits 5917 5923 +6
+ Misses 5400 5399 -1
- Partials 223 231 +8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@LeifuChen could you remove the little cross margin / isolated margin badge? @asherism are there any small design tweaks you would add to this? |
i'd maybe tweak the column widths a little - they seem a little arbitrary right now. maybe they should all be equal width? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, just a couple of small suggestions.
…order of pagination
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice changes, just a log to remove.
…he pagination style
Description
Add position history table to the
history
tab on thedashboard
pageRelated issue
Closes Kwenta/kwenta-private#26
Motivation and Context
How Has This Been Tested?
Case 1: No wallet connect
Case 2: Connecting the wallet
Screenshots (if appropriate):