Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add position history table #2709

Merged
merged 21 commits into from
Aug 1, 2023
Merged

Feat: Add position history table #2709

merged 21 commits into from
Aug 1, 2023

Conversation

LeifuChen
Copy link
Contributor

@LeifuChen LeifuChen commented Jul 29, 2023

Description

Add position history table to the history tab on the dashboard page

Related issue

Closes Kwenta/kwenta-private#26

Motivation and Context

How Has This Been Tested?

Case 1: No wallet connect

  • Go to the dashboard page and click on the history tab on the side nav
  • Find no table results for both of the tables

Case 2: Connecting the wallet

  • Go to the dashboard page and click on the history tab on the side nav
  • Find results for both of the tables

Screenshots (if appropriate):

截屏2023-07-30 13 41 08

@vercel
Copy link

vercel bot commented Jul 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
kwenta ✅ Ready (Inspect) Visit Preview Aug 1, 2023 9:15pm
kwenta-storybook ✅ Ready (Inspect) Visit Preview Aug 1, 2023 9:15pm

@codecov
Copy link

codecov bot commented Jul 29, 2023

Codecov Report

Merging #2709 (d46568d) into dev (bfc59bd) will decrease coverage by 0.01%.
Report is 24 commits behind head on dev.
The diff coverage is 43.18%.

@@            Coverage Diff             @@
##              dev    Kwenta/kwenta#2709      +/-   ##
==========================================
- Coverage   51.27%   51.26%   -0.01%     
==========================================
  Files         382      382              
  Lines       11540    11553      +13     
  Branches     2757     2752       -5     
==========================================
+ Hits         5917     5923       +6     
+ Misses       5400     5399       -1     
- Partials      223      231       +8     
Files Changed Coverage Δ
...omponents/Currency/CurrencyPrice/CurrencyPrice.tsx 52.63% <ø> (ø)
packages/app/src/components/TVChart/DataFeed.ts 21.79% <ø> (+3.04%) ⬆️
...es/app/src/sections/futures/MarketDetails/utils.ts 100.00% <ø> (ø)
...ions/futures/MobileTrade/UserTabs/PositionsTab.tsx 64.10% <0.00%> (ø)
...sections/futures/Trade/MarketsDropdownSelector.tsx 89.65% <0.00%> (ø)
...ackages/app/src/sections/futures/Trades/Trades.tsx 27.90% <ø> (ø)
...ions/futures/TradingHistory/TradesHistoryTable.tsx 45.67% <0.00%> (-0.58%) ⬇️
...p/src/sections/shared/Layout/HomeLayout/Banner.tsx 43.18% <0.00%> (+3.59%) ⬆️
packages/app/src/state/staking/selectors.ts 41.61% <ø> (-0.50%) ⬇️
packages/app/src/utils/futures.ts 58.45% <ø> (-0.58%) ⬇️
... and 22 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@avclarke
Copy link
Contributor

@LeifuChen could you remove the little cross margin / isolated margin badge?

@asherism are there any small design tweaks you would add to this?

@asherism
Copy link
Contributor

@LeifuChen could you remove the little cross margin / isolated margin badge?

@asherism are there any small design tweaks you would add to this?

i'd maybe tweak the column widths a little - they seem a little arbitrary right now. maybe they should all be equal width?

Copy link
Contributor

@avclarke avclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, just a couple of small suggestions.

packages/app/src/sections/dashboard/HistoryTabs.tsx Outdated Show resolved Hide resolved
packages/app/src/sections/dashboard/HistoryTabs.tsx Outdated Show resolved Hide resolved
packages/app/src/pages/dashboard/history.tsx Outdated Show resolved Hide resolved
packages/app/src/sections/dashboard/HistoryTabs.tsx Outdated Show resolved Hide resolved
platschi
platschi previously approved these changes Aug 1, 2023
Copy link
Contributor

@avclarke avclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes, just a log to remove.

packages/app/src/components/Table/Pagination.tsx Outdated Show resolved Hide resolved
@platschi platschi merged commit 226f17f into dev Aug 1, 2023
4 of 5 checks passed
@platschi platschi deleted the feat/position-history-table branch August 1, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants