Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trade Panel Enhancements #2798

Merged
merged 4 commits into from
Oct 4, 2023

Conversation

0xlinus
Copy link
Contributor

@0xlinus 0xlinus commented Sep 30, 2023

Description

This PR fixes issues related to the TP/SL values shown in EditStopLossAndTakeProfitModal and in SLTPInputs which display inaccurate data. It also adds extra information to the input.

Related issue

#2797

Motivation and Context

This is also a technical assessment

@vercel
Copy link

vercel bot commented Sep 30, 2023

@0xlinus is attempting to deploy a commit to the Kwenta Team on Vercel.

A member of the Team first needs to authorize it.

@0xlinus 0xlinus changed the title tasks 1 and 2 done. Trade Panel Enhancements Sep 30, 2023
@vercel
Copy link

vercel bot commented Oct 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
kwenta ✅ Ready (Inspect) Visit Preview Oct 4, 2023 1:04pm

@platschi
Copy link
Collaborator

platschi commented Oct 2, 2023

Thank you!

Two small nitpicks:

  1. Negative value text color is not correct, check styles sheet.

Colors should be:

green
g300(dark mode)
g800(light mode)

red:
r300(dark mode)
r700(light mode)

  1. Modal text should be changed to "Entry price" instead of "Last price":
Screenshot 2023-10-02 at 11 48 20

@0xlinus
Copy link
Contributor Author

0xlinus commented Oct 2, 2023

Thank you!

Two small nitpicks:

  1. Negative value text color is not correct, check styles sheet.

Colors should be:

green g300(dark mode) g800(light mode)

red: r300(dark mode) r700(light mode)

  1. Modal text should be changed to "Entry price" instead of "Last price":
Screenshot 2023-10-02 at 11 48 20

Fixed ✔️
Thanks for the feedback!

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #2798 (0075fcf) into dev (c6df349) will increase coverage by 0.00%.
The diff coverage is 45.45%.

@@           Coverage Diff           @@
##              dev    #2798   +/-   ##
=======================================
  Coverage   51.52%   51.53%           
=======================================
  Files         425      425           
  Lines       13742    13767   +25     
  Branches     3046     3059   +13     
=======================================
+ Hits         7081     7095   +14     
- Misses       6395     6405   +10     
- Partials      266      267    +1     
Files Coverage Δ
.../app/src/sections/futures/Trade/SLTPInputField.tsx 100.00% <ø> (ø)
...itPositionModal/EditStopLossAndTakeProfitInput.tsx 73.33% <0.00%> (ø)
.../app/src/sections/futures/Trade/ShowPercentage.tsx 80.76% <80.00%> (+7.08%) ⬆️
...ages/app/src/sections/futures/Trade/SLTPInputs.tsx 65.93% <47.05%> (-1.16%) ⬇️
...itPositionModal/EditStopLossAndTakeProfitModal.tsx 22.46% <0.00%> (-1.03%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

avclarke
avclarke previously approved these changes Oct 3, 2023
Copy link
Contributor

@avclarke avclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, just one small clean up suggestion but not a blocker.

@0xlinus
Copy link
Contributor Author

0xlinus commented Oct 4, 2023

Nice work, just one small clean up suggestion but not a blocker.

Good catch, thanks!

@platschi platschi merged commit 7b24d94 into Kwenta:dev Oct 4, 2023
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants