Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menkent fix add a hardcoded slippage and susd #851

Merged
merged 1 commit into from
May 17, 2022

Conversation

LeifuChen
Copy link
Contributor

Description

  1. Add a hardcoded slippage (1%) into atomic exchange
  2. Add sUSD into atomic exchange

Related issue

Kwenta/kwenta-private#620

Motivation and Context

A quick fix to the current implementation.

How Has This Been Tested?

  1. Make a swap between sUSD => sEUR on L1
  2. Check the transaction function and confirm it is using exchangeAtomically

Screenshots (if appropriate):

https://kovan.etherscan.io/tx/0x8449e7673e458b02d5c2eeea601e3fcae9d9b8eefb83a80670700d7cf23410a2
image

@vercel
Copy link

vercel bot commented May 17, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
kwenta ✅ Ready (Inspect) Visit Preview May 17, 2022 at 3:54PM (UTC)

@vercel vercel bot temporarily deployed to Preview May 17, 2022 15:54 Inactive
@platschi platschi mentioned this pull request May 17, 2022
@platschi platschi merged commit f9db83b into v2-dev May 17, 2022
@platschi platschi mentioned this pull request May 19, 2022
@platschi platschi deleted the menkent-fix-add-hardcoded-slippage-and-susd branch May 24, 2022 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants