Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

various fixes #862

Merged
merged 2 commits into from
May 20, 2022
Merged

various fixes #862

merged 2 commits into from
May 20, 2022

Conversation

platschi
Copy link
Collaborator

@platschi platschi commented May 19, 2022 •
edited
Loading

Description

  1. Improve Deposit Button text if no margin is deposited to fit within button size restraints
  2. Switch color for trading history to correctly paint shorts in red and longs in green

Related tickets

closes Kwenta/kwenta-private#612

Screenshots (if appropriate):

Before

Screen Shot 2022-05-19 at 19 40 31

After

Screen Shot 2022-05-19 at 19 42 08

Trading History Panel:

Screen Shot 2022-05-20 at 11 17 05

Last tx (trade size -20000000000000000000 = -20 ETH): https://optimistic.etherscan.io/tx/0x35079684f469f8eac4ec0dd61ce9db8d60bc4f4a0aa456c623dbd169c35bfebd#eventlog

@vercel
Copy link

vercel bot commented May 19, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
kwenta ✅ Ready (Inspect) Visit Preview May 20, 2022 at 2:26PM (UTC)

@platschi platschi changed the title fix margin text fix deposit margin button text May 19, 2022
@vercel vercel bot temporarily deployed to Preview May 19, 2022 22:45 Inactive
@platschi platschi marked this pull request as ready for review May 20, 2022 12:50
@platschi platschi requested a review from LeifuChen May 20, 2022 12:50
@platschi platschi changed the title fix deposit margin button text various fixes May 20, 2022
@vercel vercel bot temporarily deployed to Preview May 20, 2022 14:26 Inactive
LeifuChen
LeifuChen approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@LeifuChen LeifuChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@platschi platschi merged commit 9140a0f into v2-dev May 20, 2022
@platschi platschi deleted the fix/button branch May 24, 2022 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeifuChen LeifuChen LeifuChen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@platschi @LeifuChen