Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): Support representing translation args losslessly #1004

Merged
merged 6 commits into from
Dec 17, 2023
Merged

feat(api): Support representing translation args losslessly #1004

merged 6 commits into from
Dec 17, 2023

Conversation

zml2008
Copy link
Member

@zml2008 zml2008 commented Dec 9, 2023 •
edited
Loading

wip, still needs:

  • collapse hierarchy of args to just one class
  • propogate down to serializer impls

@zml2008 zml2008 added this to the 4.15.0 milestone Dec 9, 2023
@zml2008 zml2008 marked this pull request as ready for review December 10, 2023 05:41
@zml2008
Copy link
Member Author

zml2008 commented Dec 10, 2023

Still debating, we rename the args() getter to arguments() to have a different return type, do we want to rename the setters as well? I feel like that would introduce API churn for no functional change, but it would improve consistency and clarity going forward. We could also opt to delay that change to a later date?

@zml2008 zml2008 self-assigned this Dec 17, 2023
@zml2008 zml2008 added this pull request to the merge queue Dec 17, 2023
Merged via the queue into main/4 with commit 1915e23 Dec 17, 2023
5 checks passed
@zml2008 zml2008 deleted the feat/translatable-args branch December 17, 2023 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zml2008 zml2008

Labels
area: api area: serialiser/configurate3 area: serialiser/configurate4 area: text-serialiser/gson type: enhancement
Projects
None yet
Milestone
4.15.0
Development

Successfully merging this pull request may close these issues.
1 participant
@zml2008