Fix accidental float and double NaN parsing #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kashike
approved these changes
Nov 2, 2021
zml2008
approved these changes
Nov 4, 2021
This was referenced Feb 28, 2022
Merged
Merged
Merged
Merged
This was referenced Feb 28, 2022
Merged
Merged
This was referenced Mar 14, 2022
This was referenced Apr 13, 2022
This was referenced May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More cursed snbt parity issues by yours truly.
NaNdis parsed as a double with adventure, but as a String by all Vanilla versions, same for the float equivalent. I didn't test the following statement, but as far as I can tellInfinitydhappens to get caught by a NFE with the first f in the word already, but I figured an extra test case wouldn't hurt.