-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow parsing with custom Tag Resolvers #701
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Could you add a test for this behavior, and rebase? otherwise, looks good |
Joo200
force-pushed
the
feature/contextparse
branch
from
February 23, 2022 23:13
e675885
to
1c4cb06
Compare
Joo200
force-pushed
the
feature/contextparse
branch
from
February 23, 2022 23:14
1c4cb06
to
5c98011
Compare
zml2008
requested changes
Feb 23, 2022
text-minimessage/src/main/java/net/kyori/adventure/text/minimessage/Context.java
Outdated
Show resolved
Hide resolved
text-minimessage/src/main/java/net/kyori/adventure/text/minimessage/ContextImpl.java
Outdated
Show resolved
Hide resolved
kezz
requested changes
Feb 24, 2022
text-minimessage/src/main/java/net/kyori/adventure/text/minimessage/Context.java
Outdated
Show resolved
Hide resolved
text-minimessage/src/main/java/net/kyori/adventure/text/minimessage/ContextImpl.java
Outdated
Show resolved
Hide resolved
Co-authored-by: zml <zml@aoeu.xyz>
Modified and resolves #705 now |
zml2008
approved these changes
Feb 24, 2022
kezz
approved these changes
Feb 24, 2022
This was referenced Feb 28, 2022
This was referenced Feb 28, 2022
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Mar 14, 2022
This was referenced Apr 13, 2022
This was referenced May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to create a new List tag to format lists.
My minimessage syntax is:
<list:'[entry format]':'[separator]>
The entry format will have some placeholder tags so I modify the output of the list.
E.g.:
My unique list is: <list:'<red><name></red>':', '> - that's it.
In java I would call:
this should result in the output
My unique list is: Joo200, MiniDigger - that's it.
Unfortunatly I'm unable to pass the Placeholder for "name" as TagResolver:
With this PR it should be possible to pass the Context dynamic Tag Resolvers. This would be really handy.