Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nbt): Implement nameless binary serialization #968

Merged
merged 3 commits into from
Dec 18, 2023

Conversation

booky10
Copy link
Contributor

@booky10 booky10 commented Sep 1, 2023

Implements serialization of nameless compound tags. Mojang has removed these already useless names in 23w31a (1.20.2 snapshot) and this adds API for reading/writing these "nameless" compound tags.


Not sure about how it is exposed, could also be solved by specifying a boolean for read/write methods

@zml2008 zml2008 added this to the 4.15.0 milestone Oct 18, 2023
@zml2008
Copy link
Member

zml2008 commented Nov 20, 2023

I think this could be more nicely implemented with the upcoming feature flag system coming soon:tm:? Since it's sorta a version-specific serialization quirk.

@zml2008
Copy link
Member

zml2008 commented Dec 18, 2023

So giving this more thought, with the changes I would like to see in #1009 being a bit too big to squish into 4.15.0, I think we're ok to take this design more or less as-is, and revision can occur in future versions. Thank you for your contribution!

@zml2008 zml2008 added this pull request to the merge queue Dec 18, 2023
Merged via the queue into KyoriPowered:main/4 with commit 75e29ac Dec 18, 2023
3 checks passed
@booky10 booky10 deleted the feat/nameless-nbt branch December 18, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants