Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ui): break down config.html into smaller pieces #2491

Merged
merged 11 commits into from
May 13, 2024
Merged

refactor(ui): break down config.html into smaller pieces #2491

merged 11 commits into from
May 13, 2024

Commits on May 13, 2024

  1. refactor(ui): break down config.html into smaller pieces 

    Breaks that big chungus of a vue file into smaller readable vue files,
Also includes some QoL improvements, `$tp` for i18n `$t` but knows platforms,
`PlatformLayout` for slotted platform layout,
making it clearer what should load per platform and easier to add new as needed.
    @Hazer @ReenigneArcher
    Hazer authored and ReenigneArcher committed May 13, 2024
    Configuration menu
    Copy the full SHA
    27c6287 View commit details
    Browse the repository at this point in the history

  2. chore: improved init for pin too

    @Hazer @ReenigneArcher
    Hazer authored and ReenigneArcher committed May 13, 2024
    Configuration menu
    Copy the full SHA
    ec342cb View commit details
    Browse the repository at this point in the history

  3. First batch of suggestions from code review 

    Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
    @Hazer @ReenigneArcher
    Hazer and ReenigneArcher committed May 13, 2024
    Configuration menu
    Copy the full SHA
    ffe2298 View commit details
    Browse the repository at this point in the history

  4. chore: add endlines

    @Hazer @ReenigneArcher
    Hazer authored and ReenigneArcher committed May 13, 2024
    Configuration menu
    Copy the full SHA
    8c4544b View commit details
    Browse the repository at this point in the history

  5. chore: correctly add .DS_Store to gitignore

    @Hazer @ReenigneArcher
    Hazer authored and ReenigneArcher committed May 13, 2024
    Configuration menu
    Copy the full SHA
    1b2542a View commit details
    Browse the repository at this point in the history

  6. chore(ui): rename win keys, add fallback to unix

    @Hazer @ReenigneArcher
    Hazer authored and ReenigneArcher committed May 13, 2024
    Configuration menu
    Copy the full SHA
    71efb5c View commit details
    Browse the repository at this point in the history

  7. chore: revert unnecessary locale changes

    @Hazer @ReenigneArcher
    Hazer authored and ReenigneArcher committed May 13, 2024
    Configuration menu
    Copy the full SHA
    dad68f8 View commit details
    Browse the repository at this point in the history

  8. chore: code review cleanup 

    Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
    @Hazer @ReenigneArcher
    Hazer and ReenigneArcher committed May 13, 2024
    Configuration menu
    Copy the full SHA
    45bfe25 View commit details
    Browse the repository at this point in the history

  9. chore: platform i18n windows won't fallback to unix

    @Hazer @ReenigneArcher
    Hazer authored and ReenigneArcher committed May 13, 2024
    Configuration menu
    Copy the full SHA
    4a5e133 View commit details
    Browse the repository at this point in the history

  10. chore: code style fixes 

    Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
    @Hazer @ReenigneArcher
    Hazer and ReenigneArcher committed May 13, 2024
    Configuration menu
    Copy the full SHA
    a546112 View commit details
    Browse the repository at this point in the history

  11. chore: remove blank line 

    Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
    @Hazer @ReenigneArcher
    Hazer and ReenigneArcher committed May 13, 2024
    Configuration menu
    Copy the full SHA
    92dfaa4 View commit details
    Browse the repository at this point in the history