Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use prerelease logic #2553

Merged
merged 1 commit into from
May 24, 2024
Merged

ci: use prerelease logic #2553

merged 1 commit into from
May 24, 2024

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented May 22, 2024

Description

  • Use new pre-release logic.
  • Update website to dynamically determine latest version, and latest pre-release version. Only show "beta" download button if it's newer than the latest regular release.

Todo:

  • Update version checking inside of Sunshine UI
  • Update versioning in cmake
  • Move winget to release event workflow
  • Move publish brew to release event workflow (this will also require a change to homebrew-release-action)
  • Update crowdin to point to master (after merge and branch renames)
  • Update branch protection rules

Testing version check UI:

Faked a build at v0.23.1 (current latest):
image

Faked a build at v0.23.0 (outdated):
image

Cannot really test when a pre-release is available, without creating one or two. Should work though as it's the same logic. Might have to fix forward if anything comes up.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher ReenigneArcher force-pushed the ci-use-prerelease-logic branch 2 times, most recently from c840693 to a38d48e Compare May 22, 2024 18:25
Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 7.03%. Comparing base (26ceec5) to head (97a9825).
Report is 157 commits behind head on master.

Files Patch % Lines
src/config.cpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #2553      +/-   ##
=========================================
- Coverage    7.04%   7.03%   -0.01%     
=========================================
  Files          87      87              
  Lines       17697   17697              
  Branches     8405    8406       +1     
=========================================
- Hits         1246    1245       -1     
  Misses      13712   13712              
- Partials     2739    2740       +1     
Flag Coverage Δ
Linux 5.35% <0.00%> (-0.01%) ⬇️
Windows 2.56% <0.00%> (-0.01%) ⬇️
macOS-12 8.05% <0.00%> (-0.03%) ⬇️
macOS-13 7.98% <0.00%> (-0.02%) ⬇️
macOS-14 8.27% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/config.h 0.00% <ø> (ø)
src/config.cpp 4.84% <0.00%> (-0.17%) ⬇️

@ReenigneArcher ReenigneArcher force-pushed the ci-use-prerelease-logic branch 6 times, most recently from 9f38c8f to 15a275e Compare May 22, 2024 22:33
@ReenigneArcher ReenigneArcher marked this pull request as ready for review May 22, 2024 22:54
.github/workflows/update-homebrew-release.yml Outdated Show resolved Hide resolved
.github/workflows/update-homebrew-release.yml Outdated Show resolved Hide resolved
@ReenigneArcher ReenigneArcher force-pushed the ci-use-prerelease-logic branch 3 times, most recently from 7f747a2 to 2ffd470 Compare May 24, 2024 00:21
@ReenigneArcher ReenigneArcher merged commit e898be1 into master May 24, 2024
48 of 49 checks passed
@ReenigneArcher ReenigneArcher deleted the ci-use-prerelease-logic branch May 24, 2024 01:42
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants