Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(docs): use patterns to locate python venv interpreter #2757

Conversation

ReenigneArcher
Copy link
Member

Description

Locate the venv interpreter instead of assuming it's location based on the OS.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher ReenigneArcher force-pushed the build(docs)-use-patterns-to-locate-python-venv-interpreter branch from 5228bc6 to 90e37cf Compare June 25, 2024 15:20
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 8.96%. Comparing base (13f94f1) to head (90e37cf).
Report is 144 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #2757    +/-   ##
=======================================
  Coverage    8.96%   8.96%            
=======================================
  Files          94      94            
  Lines       17392   17392            
  Branches     8270    8270            
=======================================
  Hits         1560    1560            
- Misses      12963   13123   +160     
+ Partials     2869    2709   -160     
Flag Coverage Δ
Linux 6.79% <ø> (ø)
Windows 4.16% <ø> (ø)
macOS-12 10.04% <ø> (-0.02%) ⬇️
macOS-13 9.94% <ø> (-0.02%) ⬇️
macOS-14 10.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 23 files with indirect coverage changes

@ReenigneArcher ReenigneArcher enabled auto-merge (squash) June 25, 2024 15:46
@ReenigneArcher ReenigneArcher merged commit cac1ca3 into master Jun 25, 2024
49 checks passed
@ReenigneArcher ReenigneArcher deleted the build(docs)-use-patterns-to-locate-python-venv-interpreter branch June 25, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant