Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(flatpak): separate dependencies into sub-modules #2818

Merged

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Jul 7, 2024

Description

Separate flatpak dependencies into sub-modules. This is prep for flathub/dev.lizardbyte.app.Sunshine#36

In another PR, dependencies will be built from their upstream source control instead of from https://salsa.debian.org. This was used temporarily since it is what is used on flathub, but note that any patches applied there are not present here.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher ReenigneArcher force-pushed the build(flatpak)-sync-dependencies-with-flathub branch 4 times, most recently from a4fa17d to 0f7a2f1 Compare July 7, 2024 21:57
Copy link

codecov bot commented Jul 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.23%. Comparing base (3b95397) to head (7d00c3d).

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2818   +/-   ##
======================================
  Coverage    9.23%   9.23%           
======================================
  Files          97      97           
  Lines       17440   17440           
  Branches     8314    8314           
======================================
  Hits         1611    1611           
  Misses      12946   12946           
  Partials     2883    2883           
Flag Coverage Δ
Linux 6.99% <ø> (ø)
Windows 4.53% <ø> (ø)
macOS-12 10.32% <ø> (ø)
macOS-13 10.24% <ø> (+0.01%) ⬆️
macOS-14 10.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 25 files with indirect coverage changes

@ReenigneArcher ReenigneArcher force-pushed the build(flatpak)-sync-dependencies-with-flathub branch from 0f7a2f1 to 7f9762a Compare July 7, 2024 23:12
@ReenigneArcher ReenigneArcher changed the title build(flatpak): sync dependencies with flathub build(flatpak): sync dependencies with flathub (part 1) Jul 7, 2024
@ReenigneArcher ReenigneArcher changed the title build(flatpak): sync dependencies with flathub (part 1) build(flatpak): separate dependencies into sub-modules Jul 14, 2024
@ReenigneArcher ReenigneArcher marked this pull request as ready for review July 14, 2024 22:29
@ReenigneArcher ReenigneArcher force-pushed the build(flatpak)-sync-dependencies-with-flathub branch from 7f9762a to 7d00c3d Compare July 14, 2024 22:29
@ReenigneArcher ReenigneArcher enabled auto-merge (squash) July 14, 2024 22:30
@ReenigneArcher ReenigneArcher merged commit e34f446 into master Jul 14, 2024
47 checks passed
@ReenigneArcher ReenigneArcher deleted the build(flatpak)-sync-dependencies-with-flathub branch July 14, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant