Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle CTRL_CLOSE_EVENT on Windows #2952

Merged
merged 1 commit into from
Aug 3, 2024
Merged

Conversation

ns6089
Copy link
Contributor

@ns6089 ns6089 commented Aug 3, 2024

Description

This allows us to terminate gracefully when console window is closed. Mostly relevant for portable builds.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

This allows us to terminate gracefully when console window is closed.
Mostly relevant for portable builds.
Copy link

codecov bot commented Aug 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.57%. Comparing base (ecc7f2a) to head (3fb2b31).

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2952     +/-   ##
========================================
  Coverage    9.57%   9.57%             
========================================
  Files          97      97             
  Lines       17582   17582             
  Branches     8336    8336             
========================================
  Hits         1683    1683             
- Misses      13011   15097   +2086     
+ Partials     2888     802   -2086     
Flag Coverage Δ
Linux 6.95% <ø> (ø)
Windows 5.08% <ø> (ø)
macOS-12 10.29% <ø> (ø)
macOS-13 10.21% <ø> (+0.01%) ⬆️
macOS-14 10.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 31 files with indirect coverage changes

@cgutman cgutman merged commit 4fd6c66 into LizardByte:master Aug 3, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants