Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: print encoder name to info log during creation #2965

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

ns6089
Copy link
Contributor

@ns6089 ns6089 commented Aug 5, 2024

Description

We didn't indicate what encoder we were probing so the log looked very confusing.

Screenshot

[2024-08-05 13:34:51.829] Info: Creating encoder [hevc_nvenc]
[2024-08-05 13:34:51.829] Info: Color coding: SDR (Rec. 709)
[2024-08-05 13:34:51.829] Info: Color depth: 10-bit
[2024-08-05 13:34:51.830] Info: Color range: JPEG

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@ReenigneArcher ReenigneArcher changed the title Print encoder name to info log during creation fix: print encoder name to info log during creation Aug 5, 2024
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 8.33333% with 11 lines in your changes missing coverage. Please review.

Project coverage is 9.69%. Comparing base (19250f1) to head (f219a47).

Files Patch % Lines
src/video.cpp 8.33% 2 Missing and 9 partials ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2965   +/-   ##
======================================
  Coverage    9.68%   9.69%           
======================================
  Files          97      97           
  Lines       17528   17524    -4     
  Branches     8200    8204    +4     
======================================
+ Hits         1698    1699    +1     
+ Misses      12993   12987    -6     
- Partials     2837    2838    +1     
Flag Coverage Δ
Linux 7.20% <8.33%> (+0.01%) ⬆️
Windows 5.11% <0.00%> (+<0.01%) ⬆️
macOS-12 10.37% <0.00%> (+0.01%) ⬆️
macOS-13 10.26% <0.00%> (-0.02%) ⬇️
macOS-14 10.58% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/video.cpp 25.90% <8.33%> (+0.08%) ⬆️

... and 1 file with indirect coverage changes

@ReenigneArcher ReenigneArcher merged commit b6b8e68 into LizardByte:master Aug 8, 2024
46 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants