Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(macos): add beta homebrew formula #2990

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Aug 8, 2024

Description

This PR adds a beta homebrew formula. It works by doing the following, AFTER the spec is validated.

  1. rename the formula
  2. Use sed to replace 2 values
  3. Upload it to our homebrew repo

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@ReenigneArcher ReenigneArcher force-pushed the feat/macos/add-beta-homebrew-formula branch 3 times, most recently from b6d002d to 18b230b Compare August 8, 2024 21:09
packaging/sunshine.rb Outdated Show resolved Hide resolved
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.69%. Comparing base (b6b8e68) to head (fc603a4).

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2990   +/-   ##
======================================
  Coverage    9.69%   9.69%           
======================================
  Files          97      97           
  Lines       17524   17524           
  Branches     8204    8204           
======================================
  Hits         1699    1699           
  Misses      12987   12987           
  Partials     2838    2838           
Flag Coverage Δ
Linux 7.20% <ø> (ø)
Windows 5.11% <ø> (ø)
macOS-12 10.35% <ø> (ø)
macOS-13 10.26% <ø> (-0.02%) ⬇️
macOS-14 10.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ReenigneArcher ReenigneArcher force-pushed the feat/macos/add-beta-homebrew-formula branch from 18b230b to fc603a4 Compare August 8, 2024 22:46
@ReenigneArcher ReenigneArcher enabled auto-merge (squash) August 8, 2024 23:12
@Hazer Hazer mentioned this pull request Aug 9, 2024
10 tasks
@ReenigneArcher ReenigneArcher merged commit 0b8468c into master Aug 9, 2024
46 of 47 checks passed
@ReenigneArcher ReenigneArcher deleted the feat/macos/add-beta-homebrew-formula branch August 9, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants