Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(macos): fix error in macos-13 build #3022

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

ReenigneArcher
Copy link
Member

Description

Fix brew link issue in macOS-13 runners.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.69%. Comparing base (a669b36) to head (01c5e5e).

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #3022   +/-   ##
======================================
  Coverage    9.69%   9.69%           
======================================
  Files          97      97           
  Lines       17524   17524           
  Branches     8204    8204           
======================================
  Hits         1699    1699           
+ Misses      12987   12983    -4     
- Partials     2838    2842    +4     
Flag Coverage Δ
Linux 7.20% <ø> (ø)
Windows 5.11% <ø> (ø)
macOS-12 10.35% <ø> (ø)
macOS-13 10.26% <ø> (ø)
macOS-14 10.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@ReenigneArcher ReenigneArcher force-pushed the build/macos/fix-error-in-macos-13-build branch 2 times, most recently from 8d0f86d to 01c5e5e Compare August 16, 2024 00:03
Co-Authored-By: Vithorio Polten <reach@vithor.io>
@ReenigneArcher ReenigneArcher force-pushed the build/macos/fix-error-in-macos-13-build branch from 01c5e5e to 9409cf2 Compare August 16, 2024 21:56
Copy link

sonarcloud bot commented Aug 16, 2024

@ReenigneArcher ReenigneArcher enabled auto-merge (squash) August 16, 2024 22:24
@ReenigneArcher ReenigneArcher merged commit 7c4c905 into master Aug 16, 2024
45 of 47 checks passed
@ReenigneArcher ReenigneArcher deleted the build/macos/fix-error-in-macos-13-build branch August 16, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant