Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(cmake): remove v prefix from version number #3067

Merged

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Aug 22, 2024

Description

The v prefix is causing debian cpack builds to fail.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@ReenigneArcher ReenigneArcher force-pushed the build/cmake/remove-v-prefix-from-version-number branch from 99501fe to d30d3e7 Compare August 22, 2024 23:27
Copy link

sonarcloud bot commented Aug 22, 2024

@ReenigneArcher ReenigneArcher marked this pull request as ready for review August 22, 2024 23:37
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.96%. Comparing base (764ce03) to head (d30d3e7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #3067      +/-   ##
=========================================
- Coverage    7.15%   4.96%   -2.20%     
=========================================
  Files          91      67      -24     
  Lines       16464   12536    -3928     
  Branches     7780    5760    -2020     
=========================================
- Hits         1178     622     -556     
+ Misses      12687   11758     -929     
+ Partials     2599     156    -2443     
Flag Coverage Δ
Linux ?
Windows 4.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 58 files with indirect coverage changes

@ReenigneArcher ReenigneArcher merged commit 82ad648 into master Aug 23, 2024
44 of 49 checks passed
@ReenigneArcher ReenigneArcher deleted the build/cmake/remove-v-prefix-from-version-number branch August 23, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant