Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linux): use correct value for AMD_DEBUG environment variable #3115

Conversation

ReenigneArcher
Copy link
Member

Description

Fix typo reported here: bf92fda#r146064860

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@ReenigneArcher
Copy link
Member Author

@gschintgen FYI

Copy link

codecov bot commented Sep 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.69%. Comparing base (0f40a09) to head (6c48342).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #3115      +/-   ##
=========================================
- Coverage    9.70%   9.69%   -0.01%     
=========================================
  Files          77      77              
  Lines       14055   14055              
  Branches     6443    6443              
=========================================
- Hits         1364    1363       -1     
  Misses      10075   10075              
- Partials     2616    2617       +1     
Flag Coverage Δ
Windows 5.06% <ø> (ø)
macOS-12 10.75% <ø> (ø)
macOS-13 10.66% <ø> (-0.03%) ⬇️
macOS-14 10.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Copy link

sonarcloud bot commented Sep 1, 2024

@gschintgen
Copy link
Contributor

@gschintgen FYI

LGTM. I'll testdrive the 24.04 artifact in a few hours (and check the encoder clock frequencies.)

@gschintgen
Copy link
Contributor

LGTM. I'll testdrive the 24.04 artifact in a few hours (and check the encoder clock frequencies.)

It's working great:
image
Both frequencies stay high while streaming. (screenshot of amdgpu_top)

Initially I was a bit frustrated since I couldn't even get it to work with the earlier pre-release even though I correctly launched it using the AMD_DEBUG variable. I then realized that current master actually prevents lowlatency mode from working, since it unconditionally overwrites a user-provided AMD_DEBUG variable...

Anyway this PR is good news for AMD users.

Sidenote: Ubuntu 24.04 (to which I upgraded last night from the previous LTS) ships with mesa 24.0.9. Not even kisak-stable/turtle PPA is current enough. At the time being Ubuntu 24.04 users will have to install the kisak-fresh PPA. But no other tinkering is necessary.

@gschintgen
Copy link
Contributor

Another sidenote: I thought the versioning was changed/fixed. I'm wondering if this is the expected behavior:

dpkg: warning: downgrading sunshine from 2024.831.174557 to 0.0.0.6c483429b3819aa07ace4f4b66f2af8fd16ca69f

(that's when installing the build artifact of this PR)

@ReenigneArcher
Copy link
Member Author

Another sidenote: I thought the versioning was changed/fixed. I'm wondering if this is the expected behavior:

dpkg: warning: downgrading sunshine from 2024.831.174557 to 0.0.0.6c483429b3819aa07ace4f4b66f2af8fd16ca69f

(that's when installing the build artifact of this PR)

Pull requests won't get a version number.

@ReenigneArcher ReenigneArcher merged commit 697e877 into master Sep 1, 2024
37 of 38 checks passed
@ReenigneArcher ReenigneArcher deleted the fix/linux/use-correct-value-for-AMD_DEBUG-environment-variable branch September 1, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants