Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui-apps): update game db url #3148

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

ReenigneArcher
Copy link
Member

Description

CNAME will be removed from GameDB repo (formerly db). It will be removed after the next stable Sunshine release.

Could not use https://app.lizardbyte.dev/GameDB as base URL as GitHub is responding with CORS errors, I assume due to the current redirect.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Copy link

sonarcloud bot commented Sep 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 New issue
C Maintainability Rating on New Code (required ≥ A)
1 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.70%. Comparing base (87f0c27) to head (3c5518d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #3148   +/-   ##
======================================
  Coverage    9.69%   9.70%           
======================================
  Files          77      77           
  Lines       14074   14074           
  Branches     6460    6460           
======================================
+ Hits         1365    1366    +1     
  Misses      10088   10088           
+ Partials     2621    2620    -1     
Flag Coverage Δ
Windows 5.06% <ø> (ø)
macOS-12 10.78% <ø> (+0.01%) ⬆️
macOS-13 10.66% <ø> (-0.02%) ⬇️
macOS-14 10.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@ReenigneArcher ReenigneArcher merged commit cdc2d1b into master Sep 5, 2024
36 of 38 checks passed
@ReenigneArcher ReenigneArcher deleted the fix/ui-apps/update-game-db-url branch September 5, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant