Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(macos)!: drop monterey support #3236

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Sep 28, 2024

Description

macOS-12 doesn't support some newer c++ syntax, probably time to drop it. From my research many are dropping support for it in November (~1 month from now).

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Copy link

codecov bot commented Sep 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.82%. Comparing base (fceda35) to head (caf3bc3).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #3236      +/-   ##
=========================================
- Coverage    9.90%   9.82%   -0.09%     
=========================================
  Files         101     101              
  Lines       17980   17969      -11     
  Branches     8408    8408              
=========================================
- Hits         1781    1765      -16     
- Misses      13326   13327       +1     
- Partials     2873    2877       +4     
Flag Coverage Δ
Linux 7.27% <ø> (-0.07%) ⬇️
Windows 5.10% <ø> (ø)
macOS-12 ?
macOS-13 10.70% <ø> (-0.04%) ⬇️
macOS-14 10.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

@ReenigneArcher ReenigneArcher enabled auto-merge (squash) September 29, 2024 20:32
Copy link

sonarcloud bot commented Sep 29, 2024

@ReenigneArcher ReenigneArcher merged commit 434b7e0 into master Sep 29, 2024
36 checks passed
@ReenigneArcher ReenigneArcher deleted the chore/macos/drop-monterey-support branch September 29, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant