fix(api): add duplex configuration to fetch #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node sneakily introduced a change to the fetch API that now requires that the `duplex` option be set on all requests with contain a payload body: nodejs/node#46221 , which means that the CLI now fails on node >18.13, >19.1, 20, and running the CLI on those versions will cause the following exception: ``` RequestInit: duplex option is required when sending a body. Exited with code exit status 1 ``` This configures all fetch requests with bodies to set the duplex option to the only value that is allowed by the spec for now, which is `"half"`. This should have no impact on older node versions since it's the only option available, but will allow the CLI to run on those newer versions without throwing an error.
|
@eranimo sorry for the ping, but it's been a week since I proposed this PR, it's a relatively trivial change and will unblock using the CLI on recent minors of node 18/20, so I would appreciate if you could take a quick look at this :) Thank you in advance! |
Thank you, we will be reviewing this in our next cycle. |
|
verified this change |
|
This should be bundled into the latest release of the CLI, 0.13.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node sneakily introduced a change to the fetch API that now requires that the
duplexoption be set on all requests with contain a payload body: nodejs/node#46221 , which means that the CLI now fails on node >18.13, >19.1, 20, with the following exception:This configures all fetch requests with bodies to set the duplex option to the only value that is allowed by the spec for now, which is
"half". This should have no impact on older node versions since it's the only option available, but will allow the CLI to run on those newer versions without throwing an error.