Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display CGM Data in mmol vs. mg/dL #87

Closed
apabari opened this issue Jul 24, 2016 · 6 comments
Closed

Display CGM Data in mmol vs. mg/dL #87

apabari opened this issue Jul 24, 2016 · 6 comments
Assignees
Milestone

Comments

@apabari
Copy link
Contributor

apabari commented Jul 24, 2016

Was able to pull some CGM data from Dexcom Share. As a Canadian user I am displaying data in mmol; however, data is only being displayed in mg/DL in loop.

Could this be a configurable item for the CGM data graph?

@apabari apabari closed this as completed Jul 24, 2016
@apabari apabari reopened this Jul 24, 2016
@loudnate
Copy link
Collaborator

Absolutely, though no setting is necessary because the setting exists in HealthKit.
LoopKit/LoopKit#27 is a pre-requisite here.

Please don't hesitate to file any additional issues you encounter with units.

@apabari
Copy link
Contributor Author

apabari commented Jul 27, 2016

Is a code change required to enable this? My settings in HealthKit are in mmol. Interestingly, the Glucose value listed in loop (at the bottom of the app) is displayed in mmol. But the graph view is displaying in mg/DL.

@loudnate
Copy link
Collaborator

Yes, this is something I plan to fix. If you'd like to just quickly change your code in the meantime, you'll find two "TODO" items in this file.

https://github.com/loudnate/Loop/blob/master/Loop/Managers/StatusChartManager.swift

@apabari
Copy link
Contributor Author

apabari commented Aug 2, 2016

I just tried modifying the code, but I noticed that the glucose predictions are not being displayed properly when I change the units. The graph is also showing from 0 to 50 units, which makes the line almost flat regardless. I'm not sure how to change that -- my own lack of knowledge of this software language, I'm sure. If you have a chance to direct me at which lines I need to modify, in the meantime, that would be great.

Thanks!

@scottleibrand
Copy link

I believe that scale is logarithmic, not linear, so even if it goes to 50 it should still show temps.

@beached
Copy link
Contributor

beached commented Aug 3, 2016

I changed line 258 to adjust the scale. The segments where set to 25 units of whatever and a max of 4 of them. I changed it to 5 units per segment with a max of 5.

@loudnate loudnate added this to the 0.10.0 milestone Aug 6, 2016
@loudnate loudnate self-assigned this Aug 6, 2016
loudnate added a commit that referenced this issue Aug 7, 2016
Fixes #87

Removing unnecessary text rows now present in the glucose HUD

Fixes #97
erikdi pushed a commit to erikdi/Loop that referenced this issue Feb 10, 2019
* Rename xDripG5 framework to CGMBLEKit to avoid confusion with other xDrip projects
ps2 pushed a commit that referenced this issue Aug 4, 2020
* Implement suspend threshold guardrails

* Update project.pbxproj

* Tweak suspend threshold description

* Updates from design review

* Integrate InsulinSensitivityScheduleEditor

* Fix wonky suspend threshold animation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants