Fixing an issue where idle timer wasn't asserted as running unless pump data was stale #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mp data was stale
ps2
pushed a commit
that referenced
this pull request
Apr 11, 2022
…ts (#501) * Checkpoint: AlertSearcher * checkpoint * COASTAL-651: Adds PersistedAlertStore for looking up outstanding alerts Adds ability to query CoreData for all outstanding (i.e. "unretracted") alerts from a given `managerIdentifier`. https://tidepool.atlassian.net/browse/COASTAL-651 * unit tests * This makes issuing and retracting alerts synchronous, so when the functions return CoreData may be queried (This is not ideal, but in practice the performance hit will be minimal) * Better version of previous commit: make writes to AlertStore synchronous so subsequent reads get latest data. (Again, performance hit should be minimal) * PR Feedback
ps2
added a commit
that referenced
this pull request
Apr 11, 2022
* Reorder build phases for Xcode 13 * LOOP-3980 Avoid cancelling temp basal on launch. (#499) * Avoid cancelling temp basal on launch * Add test for ignoring initial value of isClosedLoop * COASTAL-651: Adds PersistedAlertStore for looking up outstanding alerts (#501) * Checkpoint: AlertSearcher * checkpoint * COASTAL-651: Adds PersistedAlertStore for looking up outstanding alerts Adds ability to query CoreData for all outstanding (i.e. "unretracted") alerts from a given `managerIdentifier`. https://tidepool.atlassian.net/browse/COASTAL-651 * unit tests * This makes issuing and retracting alerts synchronous, so when the functions return CoreData may be queried (This is not ideal, but in practice the performance hit will be minimal) * Better version of previous commit: make writes to AlertStore synchronous so subsequent reads get latest data. (Again, performance hit should be minimal) * PR Feedback * COASTAL-668: Fix crash when alert acknowledgement fails (#502) If alert acknowledgement fails, we display another in-app modal alert but need to do so on the main queue. https://tidepool.atlassian.net/browse/COASTAL-668 * COASTAL-625: Relax requirement that HUDProvider needs to provide LevelHUDView (#503) LevelHUDView is for providing a view that displays a thermometer level, which not all Pumps may provide (e.g. Coastal). This relaxes the requirement and just requires returning a BaseHUDView. https://tidepool.atlassian.net/browse/COASTAL-625 * [COASTAL-674] record already retracted alert and look up all alerts matching identifier (#504) * record already retracted alert and look up all alerts matching identifier * response to PR comments * Fix merge issues Co-authored-by: Rick Pasetto <rickpasetto@yahoo.com> Co-authored-by: Nathaniel Hamming <nate@hmtconsulting.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mp data was stale