Cleanup utility projects #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahm86
force-pushed
the
issue-425-net6-cleanup-stage1
branch
from
9deb956
to
53f24c1
Compare
rr-
reviewed
Aug 7, 2023
TRLevelToolset/IOLogic/IOManager.cs
Outdated
|
|
||
| public static TR1Level? CurrentLevelAsTR1 | ||
| public static TR1Level CurrentLevelAsTR1 |
There was a problem hiding this comment.
Wait, why are we removing the ?? This function can still return null.
There was a problem hiding this comment.
It's currently only called in the likes of the situation below, so we still check for null at that end. I find this approach cleaner, the VS warnings when nullable is on are less than helpful I find.
This is the UI when the level is null.
There was a problem hiding this comment.
I personally think it's cleaner to leave these intact. The warnings are not wrong, even if they're annoying.
There was a problem hiding this comment.
That's fair. I'll re-enable and look at clearing the warnings.
rr-
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll group projects together into separate cleanup PRs to try to keep the file numbers a bit more manageable.
This one includes the 5 utility projects - each cleanup action is in its own commit.
Part of #425.