Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TR1 secret locations #546

Merged
merged 1 commit into from
Sep 16, 2023
Merged

Conversation

lahm86
Copy link
Collaborator

@lahm86 lahm86 commented Sep 15, 2023

A handful of new secrets for TR1. Committing before I forget about them.
Part of #510.

@lahm86 lahm86 added enhancement New feature or request TR1 labels Sep 15, 2023
@lahm86 lahm86 added this to the 1.8.0 milestone Sep 15, 2023
@lahm86 lahm86 self-assigned this Sep 15, 2023
Copy link
Collaborator

@chreden chreden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume it's OK that they aren't all Lahm PackID (and one secret lost a PackID)? Hard to tell without context.

@lahm86
Copy link
Collaborator Author

lahm86 commented Sep 16, 2023

I assume it's OK that they aren't all Lahm PackID (and one secret lost a PackID)? Hard to tell without context.

Yes, so for packs there should be a maximum of 5 defined per level (tied to trigger flags for TR1 - we only add one door to reward rooms). The first one added here is a nicer secret in Lost Valley than the one where I removed the pack ID, so it takes its place - Lost Valley had 5 defined already. Cistern had only 3 defined, but the new ones I've added here all require the same technique to get them, so only one makes it into the pack (the one that happens to be harder than the others). So if that level is allocated 5 secrets in pack mode, the last one will be random.

@lahm86 lahm86 merged commit 5cf1b1a into LostArtefacts:master Sep 16, 2023
2 checks passed
@lahm86 lahm86 deleted the issue-510-tr1-secrets branch September 16, 2023 09:41
@lahm86 lahm86 modified the milestones: 1.8.0, 1.7.4 Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request TR1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants