Skip to content

Commit

Permalink
Change -chunk-must-rto-other-opt default to true.
Browse files Browse the repository at this point in the history
With 8c5d094, the LLVM bug that erroneously optimizes a `musttail
call` to a `noreturn` function is avoided.
  • Loading branch information
MatthewFluet committed Jul 22, 2019
1 parent 823815a commit c3b9905
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion mlton/control/control-flags.sml
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ val chunkMayRToSelfOpt = control {name = "chunkMayRToSelfOpt",
default = true,
toString = Bool.toString}
val chunkMustRToOtherOpt = control {name = "chunkMustRToOtherOpt",
default = false,
default = true,
toString = Bool.toString}
val chunkMustRToSelfOpt = control {name = "chunkMustRToSelfOpt",
default = true,
Expand Down
2 changes: 1 addition & 1 deletion mlton/main/main.fun
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ fun makeOptions {usage} =
(Expert, "chunk-may-rto-self-opt", " {true|false}",
"whether to optimize return/raise that may transfer to self chunk",
Bool (fn b => chunkMayRToSelfOpt := b)),
(Expert, "chunk-must-rto-other-opt", " {false|true}",
(Expert, "chunk-must-rto-other-opt", " {true|false}",
"whether to optimize return/raise that must transfer to one other chunk",
Bool (fn b => chunkMustRToOtherOpt := b)),
(Expert, "chunk-must-rto-self-opt", " {true|false}",
Expand Down

0 comments on commit c3b9905

Please sign in to comment.