Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment Canada weather displays wrong times for hourly weather #3080

Closed
briodan opened this issue Apr 5, 2023 · 3 comments
Closed

Environment Canada weather displays wrong times for hourly weather #3080

briodan opened this issue Apr 5, 2023 · 3 comments

Comments

@briodan
Copy link

briodan commented Apr 5, 2023

When configuring envcanada as the weather source the hourly time is displayed wrong, the temperatures match what is being reported by the weather station in the correct order

image
image

here is the config i'm using

		{
			"module": "weather",
			"header": "Current Weather",
			"position": "top_right",
			"config": {
				"location": "Calgary, AB",
				"weatherProvider": "envcanada",
				"siteCode": "s0000047",
				"provCode": "AB",
				"roundTemp": false,
				"type": "hourly",
				"units": "metric",
				"useKmh": false,
				"tempUnits": "metric",
				"windUnits": "metric",
				"updateInterval": 600000,
				"animationSpeed": 1000,
				"timeFormat": 12,
				"showPeriod": true,
				"showPeriodUpper": false,
				"showWindDirection": true,
				"showWindDirectionAsArrow": false,
				"useBeaufort": true,
				"lang": "en",
				"showHumidity": false,
				"showSun": true,
				"degreeLabel": true,
				"decimalSymbol": ".",
				"showIndoorTemperature": false,
				"showIndoorHumidity": false,
				"maxNumberOfDays": 5,
				"maxEntries": 12,
				"ignoreToday": false,
				"fade": false,
				"fadePoint": 0.25,
				"initialLoadDelay": 0,
				"appendLocationNameToHeader": true,
				"calendarClass": "calendar",
				"tableClass": "small",
				"onlyTemp": false,
				"showPrecipitationAmount": false,
				"colored": false,
				"showFeelsLike": true,
				"absoluteDates": false
			}

seeing this issue on both a Pi3 and a debian 11.4.0 linux vm, both using the april release, note this issue was also present in the previous release.

@rejas
Copy link
Collaborator

rejas commented Apr 9, 2023

Thx for the report @briodan can you maybe test my PR if it fixes your problem for real?

@briodan
Copy link
Author

briodan commented Apr 9, 2023

yeap that did the trick, thanks

image
image

khassel pushed a commit that referenced this issue Apr 9, 2023
Fixes #3080

---------

Co-authored-by: veeck <michael@veeck.de>
@khassel
Copy link
Collaborator

khassel commented Jul 1, 2023

fixed with new release v2.24.0

@khassel khassel closed this as completed Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants