Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[weather] openweathermap One Call 2.5 will be finally closed in June 2024 #3424

Closed
khassel opened this issue Apr 17, 2024 · 5 comments
Closed

[weather] openweathermap One Call 2.5 will be finally closed in June 2024 #3424

khassel opened this issue Apr 17, 2024 · 5 comments
Labels
needs change needs testing ready (coming with next release)

Comments

@khassel
Copy link
Collaborator

khassel commented Apr 17, 2024

via mail:

"Dear OpenWeather user,

We would like to inform you about our plans to complete the migration from One Call 2.5 to One Call 3.0 that started 2 years ago. In line with this, access to One Call 2.5 will be finally closed in June 2024.

One Call 3.0 provides you with significantly advanced business-demanded features such as a minute forecast for 1 hour, 4 days forecast for any timestamp, a daily forecast for 8 days, including a human-readable summary, historical data (45-year archive) for timestamps, and with daily aggregation, 1.5-year long-term forecast with daily aggregation, and others."

We have still 2.5 in the provider file as default, must be changed to 3.0.
@mlcampbe
Copy link

I too got the email about the change to the onecall 3.0 and have tried to do some testing and it seems that we need to change the apiVersion from 2.5 to 3.0 but we also need to change the weatherEndpoint from /weather to /onecall (at least when using the default type=current).

For example, this call works fine:
curl -v "https://api.openweathermap.org/data/3.0/onecall?lat=xxx&lon=yy&appid=zzzz"

but this fails with a 404 error:
curl -v "https://api.openweathermap.org/data/3.0/weather/?lat=xxx&lon=yy&appid=zzzz"

Is this correct in that we need to change both the apiVersion and the weatherEndpoint parameters to use the 3.0 calls after June?

@sdetweil
Copy link
Collaborator

this issue says, we need to change to fix the coming api change. whatever it takes.

you have pointed out another thing to address.

@dkallen78
Copy link
Contributor

Oh hey, I did a pull request for this! Easy change (I think)

@rejas rejas mentioned this issue Aug 9, 2024
Merged
@rejas
Copy link
Collaborator

rejas commented Aug 9, 2024

Seems the old API is shutdown now for good. Switching to the new one isnt working outofthebox, so I think this needs a little more work:

https://openweathermap.org/api shows only the onecall api being free.

  • so the weatherendpoint needs to be per default "/onecall" since the old wont work

https://openweathermap.org/api/one-call-3 shows a much simpler params:

  • only lat/long, but no location can be given

Can anyone confirm my observations? Or does openweathermap work for you?

@sdetweil
Copy link
Collaborator

sdetweil commented Aug 9, 2024

I think changing the endpoint to /onecall with v3.0 in the url works the same

@khassel khassel mentioned this issue Sep 30, 2024
Merged
khassel added a commit that referenced this issue Sep 30, 2024
@khassel @MichMich
@KristjanESPERANTO @dependabot @crazyscot @rejas @bugsounet @jkriegshauser @illimarkangur @sdetweil @vppencilsharpener @Paranoid93 @btoconnor @WallysWellies @JasonStieber @jargordon @dkallen78 @ryan-d-williams @skpanagiotis @MarcLandis
Release 2.29.0 (#3568)
94c3c69 
## [2.29.0] - 2024-10-01

Thanks to: @bugsounet, @dkallen78, @jargordon, @khassel,
@KristjanESPERANTO, @MarcLandis, @rejas, @ryan-d-williams, @sdetweil,
@skpanagiotis.

> ⚠️ This release needs nodejs version `v20` or `v22`, minimum version
is `v20.9.0`

### Added

- [compliments] Added support for cron type date/time format entries mm
hh DD MM dow (minutes/hours/days/months and day of week) see
https://crontab.cronhub.io for construction (#3481)
- [core] Check config at every start of MagicMirror² (#3450)
- [core] Add spelling check (cspell): `npm run test:spelling` and handle
spelling issues (#3544)
- [core] removed `config.paths.vendor` (could not work because `vendor`
is hardcoded in `index.html`), renamed `config.paths.modules` to
`config.foreignModulesDir`, added variable `MM_CUSTOMCSS_FILE` which -
if set - overrides `config.customCss`, added variable `MM_MODULES_DIR`
which - if set - overrides `config.foreignModulesDir`, added test for
`MM_MODULES_DIR` (#3530)
- [core] elements are now removed from `index.html` when loading script
or stylesheet files fails
- [core] Added `MODULE_DOM_UPDATED` notification each time the DOM is
re-rendered via `updateDom` (#3534)
- [tests] added minimal needed node version to tests (currently v20.9.0)
to avoid releases with wrong node version info
- [tests] Added `node-libgpiod` library to electron-rebuild tests
(#3563)

### Removed

- [core] removed installer only files (#3492)
- [core] removed raspberry object from systeminformation (#3505)
- [linter] removed `eslint-plugin-import`, because it doesn't support
ESLint v9. We will reenter it later when it does.
- [tests] removed `onoff` library from electron-rebuild tests (#3563)

### Updated

- [weather] Updated `apiVersion` default from 2.5 to 3.0 (#3424)
- [core] Updated dependencies including stylistic-eslint
- [core] nail down `node-ical` version to `0.18.0` with exception
`allow-ghsas: GHSA-8hc4-vh64-cxmj` in `dep-review.yaml` (which should
removed after next `node-ical` update)
- [core] Updated SocketIO catch all to new API
- [core] Allow custom modules positions by scanning index.html for the
defined regions, instead of hard coded (PR #3518 fixes issue #3504)
- [core] Detail optimizations in `config_check.js`
- [core] Updated minimal needed node version in `package.json`
(currently v20.9.0) (#3559) and except for v21 (no security updates)
(#3561)
- [linter] Switch to ESLint v9 and flat config and replace
`eslint-plugin-unicorn` by `@eslint/js`
- [core] fix discovering module positions twice after #3450

### Fixed

- Fixed `checks` badge in README.md
- [weather] Fixed issue with the UK Met Office provider following a
change in their API paths and header info.
- [core] add check for node_helper loading for multiple instances of
same module (#3502)
- [weather] Fixed issue for respecting unit config on broadcasted
notifications
- [tests] Fixes calendar test by moving it from e2e to electron with
fixed date (#3532)
- [calendar] fixed sliceMultiDayEvents getting wrong count and
displaying incorrect entries, Europe/Berlin (#3542)
- [tests] ignore `js/positions.js` when linting (this file is created at
runtime)
- [calendar] fixed sliceMultiDayEvents showing previous day without
config enabled

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Michael Teeuw <michael@xonaymedia.nl>
Co-authored-by: Kristjan ESPERANTO <35647502+KristjanESPERANTO@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ross Younger <crazyscot@gmail.com>
Co-authored-by: Veeck <github@veeck.de>
Co-authored-by: Bugsounet - Cédric <github@bugsounet.fr>
Co-authored-by: jkriegshauser <joshuakr@nvidia.com>
Co-authored-by: illimarkangur <116028111+illimarkangur@users.noreply.github.com>
Co-authored-by: sam detweiler <sdetweil@gmail.com>
Co-authored-by: vppencilsharpener <tim.pray@gmail.com>
Co-authored-by: veeck <michael.veeck@nebenan.de>
Co-authored-by: Paranoid93 <6515818+Paranoid93@users.noreply.github.com>
Co-authored-by: Brian O'Connor <btoconnor@users.noreply.github.com>
Co-authored-by: WallysWellies <59727507+WallysWellies@users.noreply.github.com>
Co-authored-by: Jason Stieber <jrstieber@gmail.com>
Co-authored-by: jargordon <50050429+jargordon@users.noreply.github.com>
Co-authored-by: Daniel <32464403+dkallen78@users.noreply.github.com>
Co-authored-by: Ryan Williams <65094007+ryan-d-williams@users.noreply.github.com>
Co-authored-by: Panagiotis Skias <panagiotis.skias@gmail.com>
Co-authored-by: Marc Landis <dirk.rettschlag@gmail.com>
@khassel khassel closed this as completed Sep 30, 2024
@timmymac-tech timmymac-tech mentioned this issue Oct 6, 2024
Merged
@Protonosgit Protonosgit mentioned this issue Oct 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs change needs testing ready (coming with next release)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@rejas @sdetweil @mlcampbe @khassel @dkallen78