fix ISSUE_TEMPLATE

[khassel]

fix for #3167

[codecov-commenter]

Codecov Report

Merging #3243 (b40bd32) into master (343e7de) will increase coverage by 0.08%.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master    #3243      +/-   ##
==========================================
+ Coverage   25.19%   25.28%   +0.08%     
==========================================
  Files          54       54              
  Lines       11933    11933              
==========================================
+ Hits         3007     3017      +10     
+ Misses       8926     8916      -10     

see 2 files with indirect coverage changes

[khassel]

strange these 2 old tests which are required to get the merge button visible ...

any ideas?

could try to push this commit directly on master

[rejas]

strange these 2 old tests which are required to get the merge button visible ...

very strange, especially that 14.x one...

any ideas?

could try to push this commit directly on master

I would be okay with that, if github / git allows it :-)

[rejas]

oh wait, wouldnt then the update notification be triggered for all users?

[khassel]

oh wait, wouldnt then the update notification be triggered for all users?

no, I wrote this already in the issue.

as expected:

remote: error: GH006: Protected branch update failed for refs/heads/master.
remote: error: 2 of 2 required status checks are expected.
To github.com:MichMich/MagicMirror.git
 ! [remote rejected]   master -> master (protected branch hook declined)
error: failed to push some refs to 'github.com:MichMich/MagicMirror.git'

So I think this can only be merged by @MichMich . If the "Squash and merge" button is disabled for him too he can disabled the check rule, do the merge and then enable this again.

[rejas]

After a good nights sleep I'd be fine with merging it to develop. We can live another two month with this issue after having it for so long :-)

[khassel]

@rejas moved to develop and now ready to merge

I will play with a master merge later to may find the cause of the node v14/v16 tests, couldn't reproduce this on my fork ...