Idle during long arcs #3751
Idle during long arcs #3751
Conversation
Saves about 2669 bytes when deactivated. (About 1% for a AT2560, about __4%__ for a AT644!)
|
Will close #3747, if needed we can cherry-pick from this PR. |
| @@ -6484,7 +6488,7 @@ void process_next_command() { | |||
| break; | |||
|
|
|||
| // G2, G3 | |||
| #if DISABLED(SCARA) | |||
| #if ENABLED(ARC_SUPPORT) & DISABLED(SCARA) | |||
There was a problem hiding this comment.
Oops. Two ampersands would be better here.
|
It's hard to perceive the changes, because indentation and changes are combined in a single commit. Would it be possible to add an intermediate commit, with the code changes but not the indentation, and then a commit with the indentation afterward? If that sounds tedious and annoying, I don't mind doing it myself. It just makes it much easier to see the smaller changes that were made, especially for future reference…. esp. as I will need to add similar changes to the Bézier curve support. |
|
https://github.com/MarlinFirmware/Marlin/pull/3747/files?w=1 |
| r_Y = -offset[X_AXIS] * sin_Ti - offset[Y_AXIS] * cos_Ti; | ||
| count = 0; | ||
| } | ||
| millis_t previous_ms = millis(); |
There was a problem hiding this comment.
You can shave this millis() call and init the var as 0.
There was a problem hiding this comment.
Why should i want that.
That would call idle() one time at the beginning of the loop, where we don't need it.
There was a problem hiding this comment.
It depends on the perspective..
It was a suggestion.
Idle during long arcs to prevent from watchdog resets during high segmented fast arcs.
|
I'm curious. Why do we disallow arc support with |
Idle during long arcs
to prevent from watchdog resets during high segmented fast arcs.
Includes: Make arc support (G2/G3) configurable #3747
Fix for: Crash (Hard Reset) when issuing G2/G3 command #3729