Extend M421 with I and J parameters #3798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if ((hasZ = code_seen('Z'))) z = code_value(); | ||
|
|
||
| if (hasX && hasY && hasZ) { | ||
|
|
||
| int8_t ix = mbl.select_x_index(x), | ||
| iy = mbl.select_y_index(y); | ||
|
|
||
| if (ix >= 0 && iy >= 0) | ||
| if (ix >= 0 && ix < MESH_NUM_X_POINTS && iy >= 0 && iy < MESH_NUM_Y_POINTS) |
There was a problem hiding this comment.
select_x_index and select_y_index can never return values >= to MESH_NUM_X_POINTS or MESH_NUM_Y_POINTS. If a point is too far out of range, these functions return a -1.
|
Updated. |
| @@ -5899,12 +5899,16 @@ inline void gcode_M410() { stepper.quick_stop(); } | |||
|
|
|||
| /** | |||
| * M421: Set a single Mesh Bed Leveling Z coordinate | |||
| * Eter with 'M421 Xmm Ymm Zmm' or with 'M421 In Jm Zmm' | |||
There was a problem hiding this comment.
Minor misspelling. And the word "with" isn't used quite this way in formal English. Better phrasing:
* Use either 'M421 X<mm> Y<mm> Z<mm>' or 'M421 I<xindex> J<yindex> Z<mm>'To keep "Enter … with" you could say:
* Enter 'M421' with 'X<mm> Y<mm> Z<mm>' or with 'I<xindex> J<yindex> Z<mm>'Sorry to be so pedantic. I don't mind merging this and just fixing it up later.
Extend M421 with I and J parameters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend M421 with I and J parameters to access its mesh-points directly.