Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply static to Stepper class #3922

Merged
merged 1 commit into from
Jun 3, 2016
Merged

Apply static to Stepper class #3922

merged 1 commit into from
Jun 3, 2016

Conversation

thinkyhead
Copy link
Member

Make most data and methods in the Stepper class static for size and performance.

@thinkyhead
Copy link
Member Author

I tried removing FORCE_INLINE from stepper.h and it reduced the binary size by 702 bytes. So clearly some of the methods end up not being inline-copied, but called instead. I might still try removing it from those methods where it has no effect.

@thinkyhead thinkyhead mentioned this pull request Jun 1, 2016
Closed
@thinkyhead thinkyhead added this to the 1.1.0 milestone Jun 1, 2016
@thinkyhead thinkyhead merged commit 663d246 into MarlinFirmware:RCBugFix Jun 3, 2016
@thinkyhead thinkyhead deleted the rc_statics_stepper branch June 3, 2016 00:14
@thinkyhead thinkyhead mentioned this pull request Jul 8, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: Coding Standards PR: Improvement
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
1 participant
@thinkyhead